[18.0][MIG] mail_filter_adressee_by_contact (supersede)#1841
Open
[18.0][MIG] mail_filter_adressee_by_contact (supersede)#1841
Conversation
Currently translated at 80.0% (8 of 10 strings) Translation: social-14.0/social-14.0-mail_filter_adressee_by_contact Translate-URL: https://translation.odoo-community.org/projects/social-14-0/social-14-0-mail_filter_adressee_by_contact/fr/
Currently translated at 100.0% (10 of 10 strings) Translation: social-14.0/social-14.0-mail_filter_adressee_by_contact Translate-URL: https://translation.odoo-community.org/projects/social-14-0/social-14-0-mail_filter_adressee_by_contact/es/
Kev-Roche
changed the title
metaminux
suggested changes
Apr 8, 2026
Comment on lines
+12
to
+13
| def setUpClass(cls): | ||
| super().setUpClass() |
There was a problem hiding this comment.
Suggested change
| def setUpClass(cls): | |
| super().setUpClass() | |
| def setUpClass(cls): | |
| super().setUpClass() | |
| cls.env = cls.env(context=dict(cls.env.context, tracking_disable=True)) |
There was a problem hiding this comment.
Update icon with the new one : https://github.com/OCA/maintainer-tools/blob/master/template/module/static/description/icon.png
Comment on lines
+1
to
+3
| Filter adresses by partner contacts and users. It will be applied on | ||
| mails from the following models : - account.move - sale.order - | ||
| purchase.order - stock.picking |
There was a problem hiding this comment.
To get a list in README.rst and index.html
Suggested change
| Filter adresses by partner contacts and users. It will be applied on | |
| mails from the following models : - account.move - sale.order - | |
| purchase.order - stock.picking | |
| Filter addresses by partner contacts and users. It will be applied on | |
| mails from the following models : | |
| - account.move | |
| - sale.order | |
| - purchase.order | |
| - stock.picking |
Comment on lines
+29
to
+31
| partner_ids_domain = fields.Char( | ||
| compute="_compute_partner_ids_domain", | ||
| ) |
There was a problem hiding this comment.
It is recommended to use a Binary field to store domains.
Doing that way, there's no need to cast as str or use json.dumps in the compute method.
| @@ -0,0 +1,3 @@ | |||
| from . import mail_filter_addressee_mixin | |||
| from . import mail_compose_message | |||
| from . import account_invoice_send | |||
There was a problem hiding this comment.
Maybe we should rename the file to account_move_send_wizard.py
| from odoo import models | ||
|
|
||
|
|
||
| class AccountInvoiceSend(models.TransientModel): |
There was a problem hiding this comment.
Suggested change
| class AccountInvoiceSend(models.TransientModel): | |
| class AccountMoveSendWizard(models.TransientModel): |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This migration PR supersedes #123.